And? What then?
The most important is, a) I have no clue how to force the reviewers review my pull requests, and b) I don't see why I should be doing this "forcing". These are not my monkeys; I throw the stuff over the fence, and that's it. I have no task to go begging for reviews. I'm not a team player, I'm a pro blem solver, with a rather stupid feature: I don't care which pgoblem. I can hunt, and I can gather.
Oh, and more about work. Strangely, no tests were failing, in spite of all my changes. How come, eh? Well, until I discovered that all these tests are stuffed into a monadic loop, with the IO monad. And this monad, unless you kick it to run, it does not do anything. So, somewhere at the bottom of the test one has to do .unsafeRun() - that's when it agrees to run. So, as a result, I inserted, in all the cases, a variable 'didItRun', and I check it after each test case. Not that I need it myself, but I just care about others.
And now, there's a test in this pull request that does crash. It's CompatibilitySuite. People say "you have to turn it off". At the meeting, Bill said that this test never ever worked since he joined the company. Interesting...
Of course I can, revolutionarily, remove this test, slapped together some five years ago, probably by the same Ignacio. But it's easier to just ban that test. And let the management take care of it. But the management does not have time for all this: something just got broken somewhere there (no tests?)
Well, it's not something I fully understand. If nothing ever breaks, the management at the level above will decide that Engineers are not needed anymore, etc. Let it better break. It will take a long time for these managers to reach the level of wisdom of ancient Chinese lawmakers (where doctors were only paid when nobody's sick). Since nobody is hacking us, we can lay off all those expensive security professionals. As soon as one of the banks is hacked, that's when we will hire security professionals. Like they do in Boeing: they shrank the staff, got their bonuses, run away to the next victories. And the fact that the planes' doors are falling off, that's the pilots' fault. When the pilots will be replaced with autopilots, we'll blame the robots. Is not it convenient?