Nov. 26th, 2024

dybr

Nov. 26th, 2024 07:27 pm
juan_gandhi: (Default)
Bill wrote a bunch of good notes on my PR, I fixed it all. he approved.

But then I continued improving the code (removing calls like `something.somefun(.....,None, None, None, None)`) etc.

It turned out there's about 6 files updated. So I asked Bill if he does not mind re-reviewing, but later figured I'll send it in another PR. And asked Esteban to add his review.

We were supposed to have a sprint postmortem, but there were just three of us, so we dropped it.

I found pretty weird sql injection in a bunch of code, but it turned out (with thanks to Brad and Mike and Bill) that Doobie processes all these things properly, and creates a correct sql statement, so everything's fine.

By the end of the day there was.a little bit of a panic, where one of our services started rebooting. Turned out it was because it was returning 500 all the time. And why was it? Because the service we call decided not to accept userId. It's a known feature of that team. They deployed it today, in the afternoon. Good timing.

 

Profile

juan_gandhi: (Default)
Juan-Carlos Gandhi

November 2025

S M T W T F S
       1
2345678
9101112131415
16171819202122
23242526272829
30      

Most Popular Tags

Page Summary

Style Credit

Expand Cut Tags

No cut tags
Page generated Nov. 1st, 2025 07:18 pm
Powered by Dreamwidth Studios