Three meetings.
I pinged Nick regarding my small pr with logging; he approved it, I merged, and then, at the second meeting, we discussed the logs. Turned out I can improve them; so I did.
Also, there were "alerts" coming as a result of logs analysis: too many errors in one service. I spent some time talking to people and figuring out. Eventually we came to a conclusion that 404 is not an error for the service. It's legit. No bank with such an id -> return a 404. Funny that I was looking through the names of the people who were trying to get bank info; I knew one of them, and asked him, wtf is going on, and he said that yes, 404 is not an error from the server p.o.v. Sure. So I created a case, and looked into the codebase. It's just 3 years old, and it's totally crazy.
At 3:10 we had a 1-1 with Mike; talked mostly about his plans to move to Italy, get their citizenship (he has an Italian grandfather), and work on contract. So we talked about advantages and disadvantages (I know none, except maybe money) of working on contract.
Later, after a walk, I got back to the computer, and started working on something, and discovered something like this:
I guess I may have some hard time explaining to the author how senseless it looks. Because... it's the tradition of FP! (That's how they see it.)
I pinged Nick regarding my small pr with logging; he approved it, I merged, and then, at the second meeting, we discussed the logs. Turned out I can improve them; so I did.
Also, there were "alerts" coming as a result of logs analysis: too many errors in one service. I spent some time talking to people and figuring out. Eventually we came to a conclusion that 404 is not an error for the service. It's legit. No bank with such an id -> return a 404. Funny that I was looking through the names of the people who were trying to get bank info; I knew one of them, and asked him, wtf is going on, and he said that yes, 404 is not an error from the server p.o.v. Sure. So I created a case, and looked into the codebase. It's just 3 years old, and it's totally crazy.
At 3:10 we had a 1-1 with Mike; talked mostly about his plans to move to Italy, get their citizenship (he has an Italian grandfather), and work on contract. So we talked about advantages and disadvantages (I know none, except maybe money) of working on contract.
Later, after a walk, I got back to the computer, and started working on something, and discovered something like this:
trait ImportantOperations[F: Sync: ...] { // some methods } object ImportantOperations { def impl[F: Sync: ...](param1: Option[String], param2:...) = new impl[F](param1, param2) class impl[F: Sync: ...](param1: Option[String], param2:...) { //... } }
I guess I may have some hard time explaining to the author how senseless it looks. Because... it's the tradition of FP! (That's how they see it.)