So, posted again my PR for review, and Chris did not hesitate to put new demands. "Remove these sentences from README.md" (do they break the build? Are they incorrect? - no response). "Remove this class that logs the memory usage to logger.debug" - why? Do we lose anything? It's all lazy, and has 0 impact on performance.
And I asked him if he has any objections regarding the quality and correctness of the code and its performance. Then he eventually said that he refuses to review this, and I should ask someone else.
So during the 1-1 with Karen I discussed all this, and she agreed to review - she had some RFC (requests for comments) - I love adding comments to code, so I did. We basically laughed talking about all this; now she's discussing all this with Chris, in github. I hardly participate. Just add some clarifications. Karen understands the code, and Chris obviously does not. I probably should ask Jacob too, how can I get rid of this incompetent reviewer. (Sure, using the word "incompetent" is forbidden. Last time I heard it in America, it was in the movie, "Home Alone".)
Anyway, whatever. Let them discuss. It's not my money that is being wasted during these discussions. Karen is a manager.
Also, I returned to that Oauth code transition. Gradually. Also, I started writing some new "architecture" docs; every time stopping and starting to think, no, this is a bad big picture (the previous two versions were bad too - including the docs from 5 years ago).
Anyway, I relax and enjoy. And anyway, the next quarter is coming, and there will be new stuff for me to do.
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png){kind=small}
